-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelogs for 3.12.1.0 (backport #10124) #10132
Conversation
* changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com> * fixup! changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: ffaf1 <fa-ml@ariis.it> * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 --------- Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com> Co-authored-by: ffaf1 <fa-ml@ariis.it> (cherry picked from commit 2067ed1) # Conflicts: # release-notes/Cabal-3.12.0.0.md
Cherry-pick of 2067ed1 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
I should probably mention this: worrisomely,
I merged it into this one, but suspect we need to apply it to 3.12 branch as well. |
@geekosaur we reference changelogs on master, so it's not too bad, perhaps. E.g. https://hackage.haskell.org/package/Cabal-3.12.0.0/changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will expedite unless anybody objects, since this is blocking the 3.12.1.0 release.
BTW, the "Cabal and Cabal-syntax 3.12 support GHC version 8.4.4 and up" addition was done as an afterthought in a separate PR on master, because changelogs are used on master, and apparently we forgot to backported this PR or it's languishing unmerged somewhere. No big deal, except that it's unnecessary noise. |
* Changelogs for 3.12.1.0 (haskell#10124) * changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com> * fixup! changelog for 3.12.1.0 * fixup! changelog for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 Co-authored-by: ffaf1 <fa-ml@ariis.it> * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 * fixup! Changelogs for 3.12.1.0 --------- Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com> Co-authored-by: ffaf1 <fa-ml@ariis.it> (cherry picked from commit 2067ed1) # Conflicts: # release-notes/Cabal-3.12.0.0.md * fixup! Changelogs for 3.12.1.0 (backport haskell#10124) --------- Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
Closes #10086
This is an automatic backport of pull request #10124 done by [Mergify](https://mergify.com).